Re: VPATH build failure on cygwin

[Eric Blake]

On 06/04/2015 12:50 PM, Chet Ramey wrote:
> On 6/2/15 9:10 AM, Eric Blake wrote:
> 
>> That is, the use of .: in VPATH is redundant, and will NOT find any
>> files that were not already found if you had omitted it, because make
>> already searches the current directory before resorting to VPATH.
> 
>> Thus, in all of your Makefile.in files, you should change:
> 
>> VPATH = .:@srcdir@
> 
>> to be:
> 
>> VPATH = @srcdir@
> 
>> so that bash can once again be built with the current cygwin build of
>> make; such a change will not break any other platforms.
> 
> Thanks.  As I recall, the rationale for including `.' in the VPATH had to
> do with old BSD make incompatibilities or Solaris make VPATH rewriting and
> y.tab.[ch].  I'll try your suggestion and see how it goes.

For what it's worth, lib/intl/Makefile.in already has "VPATH =
$(srcdir)" (different from everywhere else using .:@srcdir@) and no one
has complained that building lib/intl/ was broken.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature