bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: extra \1 in declare -p


From: Chet Ramey
Subject: Re: extra \1 in declare -p
Date: Wed, 22 Jul 2015 08:45:43 -0400
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 7/20/15 2:23 PM, isabella parakiss wrote:
> Hi, about this bug:
> http://lists.gnu.org/archive/html/bug-bash/2003-03/msg00093.html
> 
> The fix was to add this in lib/sh/shquote.c
>       else if (c == CTLESC || c == CTLNUL)
>         *r++ = CTLESC;
> 
> I think the fix it was applied twice, it should only check this in the
> prompt string, right?
> 
> 
> Now declare -p produces output that can't be eval'ed.
> 
> $ var=$'x\1y\177z'; declare -p var | sed -n l
> declare -- var="x\001\001y\001\177z"$
> 
> 
> Removing lines 151-152 (from the 4.4 alpha branch) seems to fix this.
> The duplicate code keeps checking the prompt in lines 297-298.
> (address@hidden is expanded by that part so it should be fine...)
> I hope it won't cause other problems.

Thanks, this looks like a good fix.  I'll check other uses of sh_double_quote.

Chet

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
                 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRU    address@hidden    http://cnswww.cns.cwru.edu/~chet/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]