[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/5] evalstring: drop volatile on sigset

From: Mike Frysinger
Subject: Re: [PATCH 5/5] evalstring: drop volatile on sigset
Date: Fri, 12 Aug 2016 00:12:09 +0800

On 11 Aug 2016 11:45, Chet Ramey wrote:
> On 8/11/16 8:30 AM, Mike Frysinger wrote:
> > These variables are located on the stack and are never read/written
> > directly by bash.  Instead, they're all accessed indirectly via the
> > POSIX signal API.  Since POSIX does not require volatile, and bash
> > itself doesn't require volatile, drop the volatile markings.  If we
> > don't, you get a lot of warnings at build time as the POSIX API does
> > not declare the prototypes with a volatile type.
> I want the values usable across a potential longjmp() regardless of what
> the compiler does and regardless of the underlying sigset_t type.  ISO C
> says the value is technically undefined after a longjmp, however unlikely
> it is that it will be modified.  volatile is the easiest way to accomplish
> that.

then can casts be added ?  building the code w/warnings is fairly verbose
due to this issue (generates like ~30 lines of warnings iirc).

Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]