[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Various improvements to tests/run-all

From: Vladimir Marek
Subject: Re: Various improvements to tests/run-all
Date: Fri, 2 Dec 2016 10:06:44 +0000
User-agent: Mutt/ (2013-10-16)

> > I am attaching patch against tests/run-all with the hope that the
> > changes can be accepted upstream. The patch should be self explanatory.
> > For completeness here are the errors I saw before I erased SHELLOPTS
> > variable
> I can see doing this.  From the error messages in your message, it seems
> like you enable posix mode via SHELLOPTS.  The tests definitely don't
> expect to be run in posix mode.

Makes sense.

> As for your other suggestions, bash-4.4 doesn't use /tmp/xx; that's a
> remnant from previous versions.  bash-4.4 sets, exports, and uses

That's my next goal - remove as many local patches as possible from our
bash build. And I'm happy that this is first one :)

> Also, sh is just used to run each test harness (e.g.,
> run-redir).  All of those scripts run the actual test scripts using
> $THIS_SH, so there's no real gain to using $THIS_SH there.

I _think_ that there was problem with running the actual 'run_*' scripts
using 'real' sh. But I don't see the problem now, so another local
change to loose I think.

Thank you

reply via email to

[Prev in Thread] Current Thread [Next in Thread]