[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bash tests failing when compiled with --enable-xpg-echo-default=yes

From: Chet Ramey
Subject: Re: bash tests failing when compiled with --enable-xpg-echo-default=yes
Date: Mon, 5 Dec 2016 16:55:51 -0500
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.5.0

On 12/4/16 8:38 AM, Vladimir Marek wrote:
>>> And second patch we use because of xpg-echo. Would it have sense to have
>>> it included, or maybe stop the tests completely instead?
>> You could just have turned off the xpg_echo option instead of going through
>> a convoluted test (which just emulates `shopt -q') to determine whether or
>> not it's on, but it does need to be off.
> Understood. I'm thinking about it this way - we have nonstandard shell
> for historic reasons. Many tests from the test suite still works fine. I
> want to test as much as possible of the shell Solaris people will be
> using. If I just disable xpg_echo, I won't be testing that. The pain of
> maintaining the tests is price for that.

Sure, I understand that, and I will make reasonable changes to accommodate
echo/echo -E.  However, you didn't do that here.  I'm ok with making the
change to just turn off xpg_echo in this file.

``The lyf so short, the craft so long to lerne.'' - Chaucer
                 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    address@hidden    http://cnswww.cns.cwru.edu/~chet/

reply via email to

[Prev in Thread] Current Thread [Next in Thread]