bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Hang in bgp_delete


From: Chet Ramey
Subject: Re: Hang in bgp_delete
Date: Thu, 16 Feb 2017 11:25:59 -0500
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.7.1

On 2/11/17 5:04 PM, Graham Northup wrote:

> Bash Version: 4.4
> Patch Level: 11
> Release Status: release
> 
> Description:
> 
> I'm getting a mysterious hang on one of our Arch Linux machines for a
> particular, rather simple script; getting a debugger attached to the
> process after building some debugging symbols, I tracked the hang down
> to this loop in bgp_delete (with some minor formatting):

It seems obvious in retrospect that the cause is in bgp_add, where there's
no check for the hashed pid colliding with the index into the pidstat list.
Here's a patch that avoids that issue and catches the symptom you found in
case the cause is something else.

Chet

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
                 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    address@hidden    http://cnswww.cns.cwru.edu/~chet/

Attachment: jobs-pid-collision.patch
Description: Source code patch

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]