bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: misleading error message from variable modifier


From: Chet Ramey
Subject: Re: misleading error message from variable modifier
Date: Sun, 4 Mar 2018 16:59:47 -0500
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 3/2/18 4:45 PM, don fong wrote:
> Chet, thanks for the explanation about CHANGES.  i am not familiar with the
> bash release process.
> 
> as for this: 
> 
>> I didn't think the tests were necessary.
> 
> what standard are you using to judge whether tests are necessary?  does the
> bash project have any coverage metrics?

It's admittedly subjective, but the bash test suite is very large and
concentrates on testing code that has undergone more changes than this,
and is more heavily used.

In this case, I didn't think a fix that added two lines of code to a
relatively stable function needed a test to ensure that it doesn't change.

> as far as i can tell, the vast majority of the C code here seems to lack
> unit tests as well.

What are the most important features that you consider to lack unit tests?

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
                 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    address@hidden    http://tiswww.cwru.edu/~chet/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]