Re: coding standards

[Clark Wang]

On Mon, Mar 5, 2018 at 9:13 AM, don fong <dfong@dfong.com> wrote:

> Clark, thanks for your answer.
>
> I use ``if (flag)'' only when `flag' is a boolean.
>
>
> but in this case, it *is* a boolean, as i stated, and as can be seen in
> subst.c:
>
> +    {
> +      if (check_nullness)
> +          report_error (_("%s: parameter null or not set"), name);
> +      else
> +          report_error (_("%s: parameter is not set"), name);
> +    }
>

Just took a look at the code and it is an int:

@@ -6849,8 +6849,9 @@ parameter_brace_expand_rhs (name, value, c, quoted,
pflags, qdollaratp, hasdolla
    used as the error message to print, otherwise a standard message is
    printed. */
 static void
-parameter_brace_expand_error (name, value)
+parameter_brace_expand_error (name, value, check_nullness)
      char *name, *value;
+     int check_nullness;
 {
   WORD_LIST *l;
   char *temp;