[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: readline-8.0-alpha: Makefile.in: don't forget to create pkgconfigdir

From: Eric Blake
Subject: Re: readline-8.0-alpha: Makefile.in: don't forget to create pkgconfigdir
Date: Thu, 24 May 2018 13:29:06 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 05/24/2018 01:18 PM, Chet Ramey wrote:
On 5/24/18 11:40 AM, gabriele balducci wrote:

just tried to build/install readline-8.0-alpha and found the following

Thanks for the report. I think a better fix is to not to attempt to
install readline.pc if $(pkgconfigdir) is missing.

Why not? If you are doing an install into DESTDIR for the purpose of bundling a pre-built binary for a distro, then $(pkgconfigdir) will be missing, because the ONLY things living in DESTDIR are what the package itself installs. When DESTDIR is empty, you're right that either $(pkgconfigdir) is likely to already exist, or that the user is not using pkg-config; but even that's a risky assumption (when bootstrapping a system, readline might be installed prior to pkg-config, and we shouldn't require the user to run 'make install' a second time just to install the pieces that weren't installed the first time).

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]