Re: [PATCH] Add active mark, face support; activate mark on paste

[gentoo_eshoes]

I wanted to mention that bash cannot detect pasted text in xfce4-terminal when 
its unsafe-paste-dialog setting is enabled and thus xfce4-terminal uses a 
dialog to ask you whether you want or not to really paste what you're pasting 
(usually any text with at least one new line inside it), because xfce4-terminal 
uses 
vte_terminal_feed_child in terminal/terminal-screen.c instead of 
vte_terminal_paste_primary/vte_terminal_paste_clipboard (which would happen 
when unsafe-paste-dialog were disabled in settings)(I mention this here: 
https://bugzilla.xfce.org/show_bug.cgi?id=16503#c6 )
I don't think there's anything bash can do, but I just thought it's good to 
know.

//////////////

Another issue/bug, with 'face', is that when the screen is full(or maybe a bit 
more than full), and thus you're already past a screenfull(80x24) of typed or 
pasted text, after the next paste(of a line of text let's say), then the next 
char you type will cause some of the pasted text to be shown after it and some 
of the highlighted text remains highlighted, but a Ctrl+L aka refresh will get 
rid of the text after and the highlight.

To repro.:
$ seq 1 1000|tr -d '\n'; echo
then double click the output text to get it into primary(?) clipboardtype: echo 
'
paste that text (by pressing MMB)
type a key, for example press 'e' , this all works as it should, thus far.
now paste the text again (MMB)
now type a key again; now it's bugged:
What you see is, the last line in terminal(80x24) is unhighlighted(this is 
good), and there is new text shown after the position of the last typed 
char(this is bad), and all the lines previous to the last line remained 
highlighted(this is bad). Pressing Ctrl+L at this point will clean it to how it 
should've looked after step 6 if it weren't bugged.

I'm attaching a screenshot of the above steps after I pressed the 'f' key at 
step 6, and a screenshot after I pressed Ctrl+L.

This can also be done with lesser-size text such as a line of 
'dddddddddddddddddddddddddddddddddddddddd' for example, it's just that you have 
to paste it a lot more times to get to a point a bit after a screenful to see 
this issue happen.

Screenshot_2020-04-12_08-30-04.png
Description: PNG image

Screenshot_2020-04-12_08-30-54.png
Description: PNG image