bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Makefile.in: Make for loop failures fatal


From: Jessica Clarke
Subject: [PATCH] Makefile.in: Make for loop failures fatal
Date: Sat, 27 Jun 2020 21:10:35 +0100

Without set -e, these for loops will exit with code 0 and so make will
regard the recipes as being successful.
---
 Makefile.in | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Makefile.in b/Makefile.in
index ee471583..a12ed426 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -752,7 +752,7 @@ Makefile makefile:  config.status $(srcdir)/Makefile.in
        CONFIG_FILES=Makefile CONFIG_HEADERS= $(SHELL) ./config.status
 
 Makefiles makefiles:   config.status $(srcdir)/Makefile.in
-       @for mf in $(CREATED_MAKEFILES); do \
+       @set -e; for mf in $(CREATED_MAKEFILES); do \
                CONFIG_FILES=$$mf CONFIG_HEADERS= $(SHELL) ./config.status ; \
        done
 
@@ -838,16 +838,16 @@ install-headers-dirs:
        @${SHELL} $(SUPPORT_SRC)mkinstalldirs $(DESTDIR)$(pkgconfigdir)
 
 install-headers: install-headers-dirs
-       @for hf in $(INSTALLED_HEADERS) ; do \
+       @set -e; for hf in $(INSTALLED_HEADERS) ; do \
                ${INSTALL_DATA} $(srcdir)/"$$hf" $(DESTDIR)$(headersdir)/$$hf; \
        done
-       @for hf in $(INSTALLED_INCFILES) ; do \
+       @set -e; for hf in $(INSTALLED_INCFILES) ; do \
                ${INSTALL_DATA} $(BASHINCDIR)/"$$hf" 
$(DESTDIR)$(headersdir)/include/$$hf; \
        done
-       @for hf in $(INSTALLED_BUILTINS_HEADERS) ; do \
+       @set -e; for hf in $(INSTALLED_BUILTINS_HEADERS) ; do \
                ${INSTALL_DATA} $(BUILTIN_SRCDIR)/"$$hf" 
$(DESTDIR)$(headersdir)/builtins/$$hf; \
        done
-       @for hf in $(CREATED_HEADERS) ; do \
+       @set -e; for hf in $(CREATED_HEADERS) ; do \
                ${INSTALL_DATA} $(BUILD_DIR)/"$$hf" 
$(DESTDIR)$(headersdir)/$$hf; \
        done
        -$(INSTALL_DATA) $(SDIR)/bash.pc $(DESTDIR)$(pkgconfigdir)/bash.pc
-- 
2.20.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]