bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

readline: remove redisplay in `rl_display_search`


From: Frédéric Moulins
Subject: readline: remove redisplay in `rl_display_search`
Date: Mon, 11 Jul 2022 19:05:17 +0200

Avoid a double redisplay when using reverse incremental search for
example. `rl_message` already calls `(*rl_redisplay_function)` before
returning, in all cases (`USE_VARARGS` or not).

---

Hello,

this was tested on bash-5.2-testing, Bash-5.2-rc1 release.
It should also apply to bash-5.1.

It looked straightforward enough to me once I spotted it.
I hope it is.


Frédéric Moulins

diff --git a/lib/readline/isearch.c b/lib/readline/isearch.c
index 3e398a6c..60fab5d7 100644
--- a/lib/readline/isearch.c
+++ b/lib/readline/isearch.c
@@ -194,7 +194,6 @@ rl_display_search (char *search_string, int flags, int 
where)
 
   rl_message ("%s", message);
   xfree (message);
-  (*rl_redisplay_function) ();
 }
 
 static _rl_search_cxt *



reply via email to

[Prev in Thread] Current Thread [Next in Thread]