Re: logic in m4/strtoimax.m4 inverted

[Emanuel Haupt]

Chet Ramey <chet.ramey@case.edu> wrote:
> On 10/1/22 6:38 AM, Emanuel Haupt wrote:
> > Static build of 5.2 fails to build on FreeBSD 13.1-RELEASE (amd64).
> > 
> > The logic in m4/strtoimax.m4 is inverted. The following patch
> > replaces strtoimax() if and only if it is present and functional.
> 
> Thanks for the report. You're right, of course.
> 
> I wonder why it fails to link, though. FreeBSD must have another
> function (probably strtoll) that bash uses defined in that same
> source file. Otherwise, wouldn't static linking skip the libc
> definition?

FreeBSD has both:
https://www.freebsd.org/cgi/man.cgi?query=strtoimax&apropos=0&sektion=3&manpath=FreeBSD+13.1-RELEASE&arch=default&format=html

Here is what's happening without the patch.

Full sandboxed build log:
https://people.freebsd.org/~ehaupt/buildlogs/bash-strtoimax/bash-static-5.2_3.log

config.log:
https://people.freebsd.org/~ehaupt/buildlogs/bash-strtoimax/config.log