Re: bash 5.2 regression in optimize_connection_fork

[Frode Nordahl]

On Sat, Nov 19, 2022 at 6:51 PM Chet Ramey <chet.ramey@case.edu> wrote:
>
> On 11/19/22 2:07 AM, Frode Nordahl wrote:
>
> > Bash Version: 5.2
> > Patch Level: 9
> > Release Status: release
> >
> > Description:
> >       OVN makes use of GNU autotest for its testsuite. This in turn is a
> > heavy user of bash.
> >
> > For some reason, when the 'ovn-controller incremental processing' test is
> > executed using bash 5.2 on Debian experimental or Ubuntu Kinetic/Lunar, the
> > `eval` [0] in the `counter_delta_` function misinterprets successful 
> > execution
> > of commands [1], leading to a false negative for the 'ovn-controller
> > incremental processing' test [2].
>
> Can you enable -x around these commands so we can at least see what the
> commands are, and maybe synthesize a reproducer from that?

Sure, the command string itself looks like this:

+++++ eval 'ovn-nbctl --wait=hv lrp-set-gateway-chassis lr1-public hv3
30 && ovn-nbctl --wait=hv sync
'

Have collected excerpts of the trace of a successful [3] and
unsuccessful run [4]. The run in [3] is collected with bash 5.2 from
tip with the revert applied, run [4] is bash 5.2 from tip.

3: https://pastebin.ubuntu.com/p/vwz9YPBCVh/
4: https://pastebin.ubuntu.com/p/SZymRBCb3P/

-- 
Frode Nordahl