Re: ld's pe-dll.c includes <stdint.h> - i386-unknown-netbsdelf1.5 barfs

[Ian Lance Taylor]

John Paul Wallington <address@hidden> writes:

> > How about partially reverting the changes in 1.68, like so:
> 
> Sorry, that's not a good idea.  I found
> http://sources.redhat.com/ml/binutils/2004-02/msg00303.html that
> describes those changes.  What is the binutils policy on <stdint.h> ?

That patch was checked in without a ChangeLog entry and was probably a
mistake.  The CVS log says "Honour PRIVATE keyword" and probably
refers to this ChangeLog entry:

2004-03-08  Danny Smith  <address@hidden>

        * pe-dll.c (pe_dll_generate_implib): Skip sections marked as
        private when building implib.


pe-dll.c should not unconditionally use <stdint.h>.  If we really
need a 32 bit type, we need to use some autoconf tests to find one.

However, as far as I can see, the code does not actually need a 32 bit
type.  It is just written sloppily.  It should unsigned char rather
than unsigned long and unsigned char, and it should compute offsets
correctly rather than assuming specific type sizes.

The patch which was accidentally checked in should be reverted, and
the code should be written correctly to not assume anything about type
sizes.

Ian