bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug binutils/630] patch included, nlmconv writes invalid nlm name in he


From: nickc at redhat dot com
Subject: [Bug binutils/630] patch included, nlmconv writes invalid nlm name in header
Date: 4 Jan 2005 15:43:00 -0000

------- Additional Comments From nickc at redhat dot com  2005-01-04 15:42 
-------
Hi Armin,

  Thanks for finding the problem and submitting a patch to fix it. 
Unfortunately there are a couple of problems with the patch - it declares a new
variable ("p") in the middle of a block of code, and it implements a function
which is already implemented in a more portable fashion in the libiberty 
library.

  So instead I am going to apply a slight variant of your patch which puts the
new code inside its own block with the variable "p" renamed to "filename" and
declared at the start of the block, and which calls the function lbasename() in
order to get the filename without any directory path prefixes.

Cheers
  Nick


-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=630

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]