Re: address@hidden: Bug#247346: Patch for the bug]

[Nick Clifton]

Hi Hakan,

> > > The attached patch (when dropped into a debian/patches folder for 
> > > binutils-avr) provides a new flag to avr-as "--allow-dollars", which 
> > > overrides the default settings to always allow dollars in function 
> > > names. Behaviour without this flag is unchanged from standard avr-as.
> >
> > It seems to me that this is the wrong way to fix this problem.  It is 
> > creating a new generic command line switch for GAS which is used to fix 
> > a problem with the AVR port.  I would be much happier with a patch that 
> > only modifies AVR specific files (ie gas/config/tc-avr.c).  A generic 
> > patch seems to me like unnecessary feature bloat.

> NesC is not only supported on the avr, but on 8051 and TI MSP430 aswell and
> possible even more arches in the future.

In which case the correct approach would be to create a 
gas/config/te-nesc.h file and arrange for this to tell gas/as.c that 
dollars are allowed in function names.  Then gas/configure.in can be 
modified to accept explicit *-*-nesc targets which will use this new 
header file.  (I assume that for NesC targets there will never be a need 
to have the old behaviour of the dollar symbol ?)

Cheers
  Nick