bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug gas/2971] New: Slash-star comments don't work for some x86 targets


From: caffer at cs dot ucc dot ie
Subject: [Bug gas/2971] New: Slash-star comments don't work for some x86 targets
Date: 27 Jul 2006 20:54:21 -0000

The hack in gas/app.c that allows both '/' and '/*' comments for i386 targets
only works when '/' is specified in the line_comment_chars array, not when it's
in the comment_chars array. These arrays are defined in gas/config/tc-i386.c,
and the array that '/' ends up in is OS dependant.

The bug could be solved by using the same hack in both cases. For convenience,
here's the relevant code:

        case LEX_IS_LINE_COMMENT_START:
          /* FIXME-someday: The two character comment stuff was badly
             thought out.  On i386, we want '/' as line comment start
             AND we want C style comments.  hence this hack.  The
             whole lexical process should be reworked.  xoxorich.  */
          if (ch == '/')
            {
              ch2 = GET ();
              if (ch2 == '*')
                {
                  old_state = 3;
                  state = -2;
                  break;
                }
              else
                {
                  UNGET (ch2);
                }
            }

-- 
           Summary: Slash-star comments don't work for some x86 targets
           Product: binutils
           Version: 2.16
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gas
        AssignedTo: unassigned at sources dot redhat dot com
        ReportedBy: caffer at cs dot ucc dot ie
                CC: bug-binutils at gnu dot org
GCC target triplet: i386-*-*


http://sourceware.org/bugzilla/show_bug.cgi?id=2971

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]