[Bug ld/3052] ld lma assignment change breaks x86-64 Linux 2.6 kernel

[hjl at lucon dot org]

------- Additional Comments From hjl at lucon dot org  2006-08-15 21:35 -------
The linker script in question:

  .vsyscall_0 -10*1024*1024: AT ((LOADADDR(.data.cacheline_aligned) +
SIZEOF(.data.cacheline_aligned) + 4095) & ~(4095)) { *(.vsyscall_0) }
  __vsyscall_0 = LOADADDR(.vsyscall_0);
  . = ALIGN(64);
  .xtime_lock : AT ((LOADADDR(.vsyscall_0) + SIZEOF(.vsyscall_0) + 63) & ~(63))
{ *(.xtime_lock) }
  xtime_lock = LOADADDR(.xtime_lock);
  . = ALIGN(16);
  .vxtime : AT ((LOADADDR(.xtime_lock) + SIZEOF(.xtime_lock) + 15) & ~(15)) {
*(.vxtime) }
  vxtime = LOADADDR(.vxtime);
  . = ALIGN(16);
  .wall_jiffies : AT ((LOADADDR(.vxtime) + SIZEOF(.vxtime) + 15) & ~(15)) {
*(.wall_jiffies) }
  wall_jiffies = LOADADDR(.wall_jiffies);
  . = ALIGN(16);
  .sys_tz : AT ((LOADADDR(.wall_jiffies) + SIZEOF(.wall_jiffies) + 15) & ~(15))
{ *(.sys_tz) }
  sys_tz = LOADADDR(.sys_tz);
  . = ALIGN(16);
  .sysctl_vsyscall : AT ((LOADADDR(.sys_tz) + SIZEOF(.sys_tz) + 15) & ~(15)) {
*(.sysctl_vsyscall) }
  sysctl_vsyscall = LOADADDR(.sysctl_vsyscall);
  . = ALIGN(16);
  .jiffies : AT ((LOADADDR(.sysctl_vsyscall) + SIZEOF(.sysctl_vsyscall) + 15) &
~(15)) { *(.jiffies) }
  jiffies = LOADADDR(.jiffies);
  . = ALIGN(16);
  .xtime : AT ((LOADADDR(.jiffies) + SIZEOF(.jiffies) + 15) & ~(15)) { 
*(.xtime) }
  xtime = LOADADDR(.xtime);
  .vsyscall_1 ADDR(.vsyscall_0) + 1024: AT (LOADADDR(.vsyscall_0) + 1024) {
*(.vsyscall_1) }
  . = LOADADDR(.vsyscall_0) + 4096;

  . = ALIGN(8192); /* init_task */
  .data.init_task : { *(.data.init_task) }

The resulting sections should be

  [14] .data.cacheline_a PROGBITS        ffffffff804dd500 4dd500 009600 00  WA 
0   0 128
  [15] .vsyscall_0       PROGBITS        ffffffffff600000 600000 000103 00  AX 
0   0  1
  [16] .xtime_lock       PROGBITS        ffffffffff600140 600140 00000c 00  WA 
0   0 64
  [17] .vxtime           PROGBITS        ffffffffff600150 600150 000038 00  WA 
0   0 16
  [18] .wall_jiffies     PROGBITS        ffffffffff600190 600190 000008 00  WA 
0   0 16
  [19] .sys_tz           PROGBITS        ffffffffff6001a0 6001a0 000008 00  WA 
0   0 16
  [20] .sysctl_vsyscall  PROGBITS        ffffffffff6001b0 6001b0 000004 00  WA 
0   0 16
  [21] .jiffies          PROGBITS        ffffffffff6001c0 6001c0 000008 00  WA 
0   0 16
  [22] .xtime            PROGBITS        ffffffffff6001d0 6001d0 000010 00  WA 
0   0 16
  [23] .vsyscall_1       PROGBITS        ffffffffff600400 600400 000028 00  AX 
0   0  1
  [24] .data.init_task   PROGBITS        ffffffff804e8000 6e8000 003000 00  WA 
0   0 32

This change:

                    last = r->last_os->output_section_statement.bfd_section; 
                    /* If the current vma overlaps the previous section,
                       then set the current lma to that at the end of
                       the previous section.  The previous section was
                       probably an overlay.  */
                    if ((dot >= last->vma
                         && dot < last->vma + last->size)
                        || (last->vma >= dot
                            && last->vma < dot + os->bfd_section->size))
                      lma = last->lma + last->size;

                    /* Otherwise, keep the same lma to vma relationship
                       as the previous section.  */
                    else
                      lma = dot + last->lma - last->vma;

                    if (os->section_alignment != -1)
                      lma = align_power (lma, os->section_alignment);
                    os->bfd_section->lma = lma;

mishandles it.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=3052

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.