[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [incomplete patch] Get objdump to report exception tables for ARM/SH
Re: [incomplete patch] Get objdump to report exception tables for ARM/SH4 correctly
Mon, 06 Aug 2007 16:22:38 +0100
Thunderbird 188.8.131.52 (X11/20070301)
2. Cleanup in my_symbol_for_address. There's none now. Should there be?
Also it looks like my_symbol_for_address is going to quite slow for large
symbol tables. You might want to consider ensuring that the symbol time is
sorted by address and then performing some kind of binary search on it. (Or do
you know that my_symbol_for_address will always be called with incrementally
increasing addresses, in which case you could just cache the last returned
value and start your search there).
3. Which macros should be used for the conditional compilation ? I've
#if defined(ARM_WINCE) || defined(SH4)
in my code. This happens to work for me because our build chain defines
ARM_WINCE, but I don't suppose this is right.
The correct way to handle this is to add a new function pointer field to the
bfd_coff_backend_data structure. Arrange for this field to be initialized by
the various backends that need it (IA64, ARM, MIPS, SH) pointing at static
functions defined in the appropriate target specific source file (pe-arm.c
etc), and otherwise for it to be empty(*). Then in
_bfd_XX_print_private_bfd_data_common test the field and call it if it is not
(*) Or maybe to point at a default pdata display function which does not try to
provide any target specific interpretation.