[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug binutils/5713] strings: use '-0' as option will meet infinite loop

From: nickc at redhat dot com
Subject: [Bug binutils/5713] strings: use '-0' as option will meet infinite loop
Date: 15 Feb 2008 10:25:13 -0000

------- Additional Comments From nickc at redhat dot com  2008-02-15 10:25 
Hi Chu,

  Thanks for pointing that out.  In fact the integer_arg() function is
completely redundant as the C library function strtoul() does everything that is
needed.  So I have applied a revised version of the patch which removes the
function entirely.

  I hope that this resolves the issue for you.


2008-02-15  Chu Li  <address@hidden>
            Nick Clifton  <address@hidden>

        PR binutils/5713
        * strings.c (integer_arg): Delete function.
        (string_min): Initialise to 4.
        (main): Use strtoul to parse integer arguments.
        Move check for an invalid string length to after all the arguments
        have been parsed.
        (usage): Use indentation to indicate that -<n> is a another form
        of the --bytes= command line option.

           What    |Removed                     |Added
             Status|WAITING                     |RESOLVED
         Resolution|                            |FIXED


------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]