[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [incomplete patch] Get objdump to report exception tables for ARM/SH

From: Nick Clifton
Subject: Re: [incomplete patch] Get objdump to report exception tables for ARM/SH4 correctly
Date: Fri, 04 Apr 2008 08:10:27 +0100
User-agent: Thunderbird (X11/20080213)

Hi Danny,

_IMAGE_CE_RUNTIME_FUNCTION_ENTRY formatted data right ? One day someone might want to write a MIPS version of this function, so we will need a

Looks like you got interrupted while writing this sentence. Not sure
what you mean.

Oops! I meant that in the future there might be other versions of this function to handle other compression schemes. So by including an indication of the compression format being handled in the name of the function you are future-proofing it.

Didn't know about that. I've used it, and added one or more lines to 30
other .c files. In most cases this is just

#define bfd_pe_print_pdata NULL

Shouldn't that be:

  #define bfd_pe_print_pdata pe_print_data

ie use the default print_pdata routine if compressed pdata is not supported by the target.

That addresses the build problems with "--enable-targets=all". This is
what you wanted me to do, right ?


One more question though. I moved my pe_print_ce_compressed_pdata
function into pe-arm-wince.c , it was in peXXigen.c in my initial patch.
The peXXigen.c doesn't seem right for this because this function is not
to be treated with the XX replacement stuff. However, pe-arm-wince.c
doesn't seem right either because the pe_print_ce_compressed_pdata
function is to be used both for ARM and for SH.

So where should I put it (and its helper functions) ?

I would actually suggest leaving it in peXXigen.c. The current pe_print_pdata function lives there and it does not make use of the XX replacement stuff. Make sure that it is static though, since peXXigen.c can be included multiple times in a single build.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]