bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug ld/10858] ld generate broken PIE binaries on MIPS


From: aurelien at aurel32 dot net
Subject: [Bug ld/10858] ld generate broken PIE binaries on MIPS
Date: 3 Nov 2009 13:03:30 -0000

------- Additional Comments From aurelien at aurel32 dot net  2009-11-03 13:03 
-------
I have been able to bisect the bug further, here is the changeset that causes 
the problem:

2008-08-07  Richard Sandiford  <address@hidden>

       * elfxx-mips.c (mips_got_info): Add a "reloc_only_gotno" field.
       (mips_elf_got_section): Delete.
       (mips_elf_sort_hash_table): Use g->reloc_only_gotno to decide
       how many reloc-only entries there are.
       (mips_elf_count_got_symbols): Adjust g->reloc_only_gotno as
       well as g->global_gotno.
       (mips_elf_make_got_per_bfd): Initialize reloc_only_gotno.
       (mips_elf_multi_got): Likewise.  Use gg->reloc_only_gotno
       rather than gg->assigned_gotno to store the number of
       reloc-only GOT entries.
       (mips_elf_create_got_section): Remove the MAYBE_EXCLUDE parameter.
       Initialize reloc_only_gotno.
       (mips_elf_calculate_relocation): Check htab->got_info instead of
       dynobj when deciding whether to call mips_elf_adjust_gp,
       (_bfd_mips_elf_create_dynamic_sections): Adjust the call
       to mips_elf_create_got_section.
       (mips_elf_record_relocs): Likewise.  Remove redundant
       "dynobj == NULL" code.  Do not use mips_elf_create_got_section
       or mips_elf_record_global_got_symbol for R_MIPS_32, R_MIPS_REL32
       and R_MIPS_64; limit global_got_area to GGA_RELOC_ONLY instead.
       (_bfd_mips_elf_finish_dynamic_symbol): Use htab->sgot instead
       of mips_elf_got_section.
       (_bfd_mips_vxworks_finish_dynamic_symbol): Likewise.
       (_bfd_mips_elf_finish_dynamic_sections): Likewise.
       Move the initial assignment of G to the block that uses it;
       it is used for an unrelated purpose later.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10858

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]