[Bug gas/10143] Failed compilation at bfin-parse.c

[nickc at redhat dot com]

------- Additional Comments From nickc at redhat dot com  2010-03-11 17:08 
-------
Hi Mike,

> was there a reason for also changing the error buffer from the stack to 
> static ?
> 
> adding the printf string "%s" makes sense, but it doesnt seem like it needs a
> static keyword added ...

It is an old habit from my embedded programming days.  Creating a large local
buffer uses up a lot of stack space and it can even prevent the program from
working if stack space is very tight.  Making the buffer static does not affect
the execution of the program (apart from increasing its data space requirement)
and it can allow the program to continue working.

In this particular case however I agree that is very unlikely that this change
is going to make any real difference.  If you really want I will revert it.

Cheers
  Nick


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10143

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.