[Bug binutils/11983] libbfd reuses pointer passed to bfd_openr

[carlo at alinoe dot com]

------- Additional Comments From carlo at alinoe dot com  2010-09-27 16:18 
-------
Hi, I'm sorry I still haven't the time to actually test this.
So, instead I just looked at the patch :p.  It looks good,
I'm sure it would solve my problem in the sense that if I tried
it it would work. Nevertheless the following remarks:
1) if (x) free(x);  seems to make little sense. free(0) works fine.
2) I didn't check if you missed an instance of assignment to the filename 
member.
3) Some applications (like mine) might already strdup the filename passed to
libbfd themselves because of this, so there needs to be some documentation about
this (change), still.

Can't think of any other remarks that would apply.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW


http://sourceware.org/bugzilla/show_bug.cgi?id=11983

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.