[Bug gold/10708] "out of file descriptors and couldn't close any" -- probably fd leak

[bes.wll at telia dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=10708

Bengt-Erik Soderstrom <bes.wll at telia dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bes.wll at telia dot com

--- Comment #11 from Bengt-Erik Soderstrom <bes.wll at telia dot com> 
2011-02-26 17:40:37 UTC ---
(In reply to comment #10)
> I found another leak that will explain the problem -- if you're using the
> --no-keep-files-mapped option (or a 32-bit build of gold, for which that's the
> default) and --gc-sections and/or --icf.
> 
> Can you try the patch below and let me know if it fixes the problem for you?
> 
> -cary
> 
> 
> Index: gold.cc
> ===================================================================
> RCS file: /cvs/src/src/gold/gold.cc,v
> retrieving revision 1.85
> diff -u -p -r1.85 gold.cc
> --- gold.cc     14 Oct 2010 22:10:22 -0000      1.85
> +++ gold.cc     3 Nov 2010 23:39:44 -0000
> @@ -359,6 +359,7 @@ queue_middle_tasks(const General_options
>            p != input_objects->relobj_end();
>            ++p)
>         {
> +          Task_lock_obj<Object> tlo(task, *p);
>           (*p)->layout(symtab, layout, NULL);
>         }
>     }


I just found this behaviour when building Chromium on a 32 bit machine using
Gold (binutils 2.21) and Fedora 14. Building from the same source, but in a 64
bit environment was OK. (Ubuntu 10.10 binutils 2.21).
Chromium was OK some week ago with the Gold linker with the Fedora 14 (32-bit).
I tried again, but this time linking with the normal ld, that is, not using
Gold, and then, the build was successful.

I did not yet try your patch, but I will, and let you know.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.