bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug ld/12474] New: mingw target should reference windows.h instead of W


From: dongsheng.song at gmail dot com
Subject: [Bug ld/12474] New: mingw target should reference windows.h instead of Windows.h
Date: Wed, 6 Apr 2011 07:56:33 +0000

http://sourceware.org/bugzilla/show_bug.cgi?id=12474

           Summary: mingw target should reference windows.h instead of
                    Windows.h
           Product: binutils
           Version: 2.22 (HEAD)
            Status: RESOLVED
          Severity: critical
          Priority: P2
         Component: ld
        AssignedTo: address@hidden
        ReportedBy: address@hidden


Dongsheng Song <dongsheng.song at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

There have 3 files reference of Windows.h:

ld/config.in:
AC_CHECK_HEADERS([Windows.h],[enable_plugins=yes],[],[AC_INCLUDES_DEFAULT])
ld/configure: ...

ld/plugin.c: #include <Windows.h>

But in the mingw or mingw-w64 repository, the name should be windows.h:

http://cygwin.com/cgi-bin/cvsweb.cgi/src/winsup/w32api/include/?cvsroot=src

https://mingw-w64.svn.sourceforge.net/svnroot/mingw-w64/trunk/mingw-w64-headers/include/

So in an case sensitive filesystem/platform, AC_CHECK_HEADERS will fail, and
the plugin will not build.

--- Comment #1 from Dongsheng Song <dongsheng.song at gmail dot com> 2011-04-06 
07:56:31 UTC ---
commit b6d40962544d522ac71d42dca804ea686a650f4d
Author: Joseph Myers <address@hidden>
Date:   Mon Mar 28 10:27:07 2011 +0000

        * configure.in: Check for windows.h, not Windows.h.
        * configure: Regenerate.
        * plugin.c: Include windows.h, not Windows.h.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]