bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug ld/12614] mingw ld omits needed jump stubs in link involving --star


From: dklprogramming at web dot de
Subject: [Bug ld/12614] mingw ld omits needed jump stubs in link involving --start/end-group
Date: Wed, 27 Apr 2011 19:12:17 +0000

http://sourceware.org/bugzilla/show_bug.cgi?id=12614

--- Comment #1 from dklprogramming at web dot de 2011-04-27 19:11:59 UTC ---
Hi,

this is my first time hacking the binutils/ld sources, but I think I may have
identified the problem.

There is a block of code in src/ld/emultempl/pe.em that tries to detect
redundant jump stubs and marks them for exclusion. It checks each symbol in the
stub section to find out whether it is used or not. However, only the symbol's
u.undef.next field (in struct bfd_link_hash_entry) is checked to determine
whether the symbol is in the undefined list or not.

This is not enough if the symbol is at the end of the list, because then the
next pointer will be NULL, even though the symbol is in the undefined list. In
the attached patch I have added a check against link_info.hash->undefs_tail to
cover that case.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]