[Bug binutils/13292] Binutils uses "struct stat" instead of "#include <sys/stat.h>"

[pgquiles at elpauer dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=13292

--- Comment #5 from Pau Garcia i Quiles <pgquiles at elpauer dot org> 
2011-10-20 12:29:30 UTC ---
(In reply to comment #4)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > (In reply to comment #0)
> > > > Created attachment 5984 [details]
> > > > Fix
> > > > 
> > > > mingw-w64 recently implemented support for large files using
> > > > _FILE_OFFSET_BITS=64.
> > > > 
> > > > Binutils uses "struct stat" instead of "#include <sys/stat.h>", which 
> > > > makes it
> > > > fail to compile with mingw-w64 trunk.
> > > > 
> > > > The attached patch fixes the issue.
> > > 
> > > I think you shouldn't edit bfd/bfd-in2.h since it is auto generated.
> > > The bfd-in.h is the file you want to patch, I guess.
> > 
> > You are right. I'm attaching a new patch against bfd/bfd-in.h (which is
> > essentially the same).
> > 
> > 
> > > The patch doesn't seem to solve the problem for me.
> > 
> > What is the problem you are experiencing now? What compiler are you trying?
> 
> I'm using gcc 4.7 (trunk).
> 
> ../../../binutils/bfd/archive.c: In function 'bfd_ar_hdr_from_filesystem':
> ../../../binutils/bfd/archive.c:1841:7: error: passing argument 1 of 'time'
> from incompatible pointer type [-Werror]
> In file included from
> j:\cross-gcc\bin\../lib/gcc/i686-w64-mingw32/4.7.0/../../../../i686-w64-mingw32/include/sys/time.h:10:0,
>                  from ../../../binutils/bfd/sysdep.h:64,
>                  from ../../../binutils/bfd/archive.c:130:
> j:\cross-gcc\bin\../lib/gcc/i686-w64-mingw32/4.7.0/../../../../i686-w64-mingw32/include/time.h:241:29:
> note: expected 'time_t *' but argument is of type '__time64_t *'
> cc1.exe: all warnings being treated as errors

I see.

I am compiling a cross binutils CVS with gcc 4.6.1 on Linux. No, I am not
seeing that problem.

> 
> > 
> > 
> > > Do you have the issue bfd/archive.c?
> > 
> > Sorry, I don't understand :-?
> 
> Sorry, I wanted to ask if you also experienced the compile error in
> bfd/archive.c or somewhere else?

No, I do not have that problem.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.