[Bug binutils/14567] bfd_openr_next_archived_file is incompatible with bfd_openr_iovec

[amodra at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14567

Alan Modra <amodra at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amodra at gmail dot com

--- Comment #2 from Alan Modra <amodra at gmail dot com> 2012-09-10 23:43:06 
UTC ---
The patch is not correct, as you would have seen if you had run the current
binutils testsuite.  The following might work a little better.

Index: bfd/opncls.c
===================================================================
RCS file: /cvs/src/src/bfd/opncls.c,v
retrieving revision 1.73
diff -u -p -r1.73 opncls.c
--- bfd/opncls.c    20 Aug 2012 14:32:31 -0000    1.73
+++ bfd/opncls.c    10 Sep 2012 23:37:49 -0000
@@ -107,6 +107,8 @@ _bfd_new_bfd (void)
   return nbfd;
 }

+static const struct bfd_iovec opncls_iovec;
+
 /* Allocate a new BFD as a member of archive OBFD.  */

 bfd *
@@ -119,6 +121,8 @@ _bfd_new_bfd_contained_in (bfd *obfd)
     return NULL;
   nbfd->xvec = obfd->xvec;
   nbfd->iovec = obfd->iovec;
+  if (obfd->iovec == &opncls_iovec)
+    nbfd->iostream = obfd->iostream;
   nbfd->my_archive = obfd;
   nbfd->direction = read_direction;
   nbfd->target_defaulted = obfd->target_defaulted;

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.