[Bug ld/14591] Wrong symbol type with common symbol and weak function

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14591



--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> 2012-09-24 12:22:57 UTC ---

CVSROOT:    /cvs/src

Module name:    src

Branch:     binutils-2_23-branch

Changes by:    address@hidden    2012-09-24 12:22:49



Modified files:

    bfd            : ChangeLog elf-bfd.h elf32-sh-symbian.c 

                     elflink.c 

    ld/testsuite   : ChangeLog 

    ld/testsuite/ld-elf: comm-data.exp 

    ld/testsuite/ld-ifunc: ifunc.exp 

Added files:

    ld/testsuite/ld-elf: comm-data3.sd comm-data3a.s comm-data3b.s 

    ld/testsuite/ld-ifunc: ifunc-17a-i386.d ifunc-17a-x86-64.d 

                           ifunc-17a.s ifunc-17b-i386.d 

                           ifunc-17b-x86-64.d ifunc-17b.s 

                           ifunc-common-1.out ifunc-common-1a.c 

                           ifunc-common-1b.c 



Log message:

    bfd/

    2012-09-18  H.J. Lu  <address@hidden>



    PR ld/14591

    * elf-bfd.h (_bfd_elf_merge_symbol): Add an argument to return

    if the old symbol is weak.



    * elf32-sh-symbian.c (sh_symbian_relocate_section): Update

    _bfd_elf_merge_symbol call.



    * elflink.c (_bfd_elf_merge_symbol): Add an argument to return

    if the old symbol is weak.

    (_bfd_elf_add_default_symbol): Update _bfd_elf_merge_symbol

    call.

    (elf_link_add_object_symbols): Don't update symbol type from a

    weak definition.  Update symbol type from a common symbol when

    overriding a weak symbol.



    ld/testsuite/

    2012-09-18  H.J. Lu  <address@hidden>



    PR ld/14591

    * ld-elf/comm-data.exp (run_ld_link_tests): Add comm-data3a and

    comm-data3b tests.



    * ld-ifunc/ifunc.exp (run_ld_link_exec_tests): New.



    * ld-elf/comm-data3.sd: New file.

    * ld-elf/comm-data3a.s: Likewise.

    * ld-elf/comm-data3b.s: Likewise.

    * ld-ifunc/ifunc-17a-i386.d: Likewise.

    * ld-ifunc/ifunc-17a-x86-64.d: Likewise.

    * ld-ifunc/ifunc-17a.s: Likewise.

    * ld-ifunc/ifunc-17b-i386.d: Likewise.

    * ld-ifunc/ifunc-17b-x86-64.d: Likewise.

    * ld-ifunc/ifunc-17b.s: Likewise.

    * ld-ifunc/ifunc-common-1.out: Likewise.

    * ld-ifunc/ifunc-common-1a.c: Likewise.

    * ld-ifunc/ifunc-common-1b.c: Likewise.



Patches:

http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/ChangeLog.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=1.5758.2.17&r2=1.5758.2.18

http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf-bfd.h.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=1.343.2.1&r2=1.343.2.2

http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elf32-sh-symbian.c.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=1.15&r2=1.15.12.1

http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/elflink.c.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=1.450.4.1&r2=1.450.4.2

http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ChangeLog.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=1.1579.2.5&r2=1.1579.2.6

http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-elf/comm-data3.sd.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=NONE&r2=1.1.2.1

http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-elf/comm-data3a.s.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=NONE&r2=1.1.2.1

http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-elf/comm-data3b.s.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=NONE&r2=1.1.2.1

http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-elf/comm-data.exp.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=1.3&r2=1.3.2.1

http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-ifunc/ifunc-17a-i386.d.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=NONE&r2=1.1.2.1

http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-ifunc/ifunc-17a-x86-64.d.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=NONE&r2=1.1.2.1

http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-ifunc/ifunc-17a.s.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=NONE&r2=1.1.2.1

http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-ifunc/ifunc-17b-i386.d.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=NONE&r2=1.1.2.1

http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-ifunc/ifunc-17b-x86-64.d.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=NONE&r2=1.1.2.1

http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-ifunc/ifunc-17b.s.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=NONE&r2=1.1.2.1

http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-ifunc/ifunc-common-1.out.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=NONE&r2=1.1.2.1

http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-ifunc/ifunc-common-1a.c.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=NONE&r2=1.1.2.1

http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-ifunc/ifunc-common-1b.c.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=NONE&r2=1.1.2.1

http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-ifunc/ifunc.exp.diff?cvsroot=src&only_with_tag=binutils-2_23-branch&r1=1.13&r2=1.13.2.1



-- 

Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email

------- You are receiving this mail because: -------

You are on the CC list for the bug.