[Bug ld/14718] ld crashes on ARMv5 due to unaligned memory access

[siarhei.siamashka at gmail dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14718



--- Comment #9 from Siarhei Siamashka <siarhei.siamashka at gmail dot com> 
2012-10-14 22:50:44 UTC ---

(In reply to comment #6)

> I would be very careful with swapping because the size of the

> arm_local_iplt_info* is unknown (could be 64-bit or anything). It would still

> work, but just by accident, because we would allocate 2*num_syms of 32-bit

> objects first, making sure the 64-bit pointers that follow are aligned.



Thanks for pointing this. Indeed, the sizes of vma typedefs and the sizes of

pointers can make some really weird combinations.



> So I strongly prefer the manual alignment approach; it's unlikely that

> a small change in the code would break it.



This or the suggestion from Andreas Schwab with separate allocations.



One nitpick about your patch is the unnecessary realignment for the char array

(sizeof(char) is always 1).



-- 

Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email

------- You are receiving this mail because: -------

You are on the CC list for the bug.