[Bug gas/15602] .word L2-L1 fails to diagnose offsets larger than 16 bits, resulting in broken jump tables on m68k

[hp at sourceware dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=15602

Hans-Peter Nilsson <hp at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hp at sourceware dot org

--- Comment #6 from Hans-Peter Nilsson <hp at sourceware dot org> ---
(In reply to Mikael Pettersson from comment #5)

>  tc_m68k_check_adjusted_broken_word (addressT new_offset, struct broken_word

> -  if (new_offset > 0xffff)
> +  if (new_offset > 0x7fff)

> since, as Andreas wrote, the offsets are signed and must fit in [0,32K-1].

I'd humbly suggest copy-pasting the definition from the CRIS port to get it
right
(using offsetT and explicit limit checking, not relying on addressT being
unsigned).

-- 
You are receiving this mail because:
You are on the CC list for the bug.