[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug binutils/16952] PowerPC LD requests bug report. Issue related to EA

From: cvs-commit at gcc dot gnu.org
Subject: [Bug binutils/16952] PowerPC LD requests bug report. Issue related to EABI symbols _SDA_BASE_, _SDA2_BASE_
Date: Tue, 20 May 2014 03:44:38 +0000


--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".

The branch, master has been updated
       via  93d1b056cb396d6468781fe0e40dd769891bed32 (commit)
      from  ab2f2ff937b25a8ee2ff902fd0bf08299d1dae2e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit 93d1b056cb396d6468781fe0e40dd769891bed32
Author: Alan Modra <address@hidden>
Date:   Tue May 20 11:42:42 2014 +0930

    Rewrite ppc32 backend .sdata and .sdata2 handling

    1) _SDA_BASE_ and _SDA2_BASE_ and defined automatically, in a similar
       manner to the way _GLOBAL_OFFSET_TABLE_ is handled.  It's a little
       more complicated to remove the symbols because _SDA_BASE_ needs to
       be there if either .sdata or .sbss is present, and similarly for
    2) The linker created .sdata and .sdata2 sections used for
       R_PPC_EMB_SDAI16 and R_PPC_EMB_SDA2I16 pointers are created early.
       Nowadays we strip unneeded sections from the output, so it isn't
       necessary to delay creating the sections.
    3) The output section for targets of various SDA relocs is now checked
       as per the ABI(s).  We previously allowed .sdata.foo and similar,
       most likely because at some stage we were checking input sections.

    Also, the patch fixes a long-standing bug in size_input_sections
    that affects the values of symbols defined in stripped input

        PR 16952
        * elf32-ppc.c (ppc_elf_create_linker_section): Move earlier.
        Remove redundant setting of htab->elf.dynobj.  Don't align.
        Define .sdata symbols using _bfd_elf_define_linkage_sym.
        (ppc_elf_create_glink): Call ppc_elf_create_linker_section.
        (create_sdata_sym): Delete.
        (elf_allocate_pointer_linker_section): Rename from
        elf_create_pointer_linker_section.  Align section.
        (ppc_elf_check_relocs): Don't call ppc_elf_creat_linker_section
        directly here, or create_sdata_sym.  Set ref_regular on _SDA_BASE_
        and _SDA2_BASE_.
        (ppc_elf_size_dynamic_sections): Remove ATTRIBUTE_UNUSED on param.
        Remove unnecessary tests on _SDA_BASE_ sym.
        (maybe_strip_sdasym, ppc_elf_maybe_strip_sdata_syms): New functions.
        (ppc_elf_relocate_section): Tighten SDA reloc symbol section checks.
        * elf32-ppc.h (ppc_elf_set_sdata_syms): Delete.
        (ppc_elf_maybe_strip_sdata_syms): Declare.
        * emulparams/elf32ppccommon.sh (_SDA_BASE_, _SDA2_BASE_): Delete.
        * emultempl/ppc32elf.em (ppc_before_allocation): Call
        * ldlang.c (size_input_section): Correct output_offset value
        for excluded input sections.


Summary of changes:
 bfd/ChangeLog                   |   20 ++++
 bfd/elf32-ppc.c                 |  218 ++++++++++++++++++++-------------------
 bfd/elf32-ppc.h                 |    2 +-
 ld/ChangeLog                    |    9 ++
 ld/emulparams/elf32ppccommon.sh |    2 -
 ld/emultempl/ppc32elf.em        |    2 +
 ld/ldlang.c                     |   15 +--
 7 files changed, 150 insertions(+), 118 deletions(-)

You are receiving this mail because:
You are on the CC list for the bug.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]