bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug binutils/17481] addr2line fails on some targets


From: cvs-commit at gcc dot gnu.org
Subject: [Bug binutils/17481] addr2line fails on some targets
Date: Tue, 28 Oct 2014 06:41:20 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=17481

--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".

The branch, binutils-2_25-branch has been updated
       via  986b34e134011175be26b4504ba8a4f8e38de2bf (commit)
       via  952d0b7d11c8e13f74df3651b28c4d49bc4d9d80 (commit)
      from  439053893173a0883defd7ded3b539b8bcfe6e07 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=986b34e134011175be26b4504ba8a4f8e38de2bf

commit 986b34e134011175be26b4504ba8a4f8e38de2bf
Author: Alan Modra <address@hidden>
Date:   Wed Oct 15 21:52:20 2014 +1030

    Merge bfd_find_nearest_line variants

    When bfd_find_nearest_line_discriminator was added, not enough care
    was taken to ensure all targets had a proper definition of the function.
    This patch cures that by merging bfd_find_nearest_line_discriminator
    and bfd_find_nearest_line target implementations.

        PR 17481
        * aoutx.h (NAME (aout, find_nearest_line)): Add "discriminator_ptr"
        param, group "section" and "offset" params.  Zero discriminator.
        * bfd.c (bfd_find_nearest_line): Implement with new
        _bfd_find_nearest_line.
        (bfd_find_nearest_line_discriminator): Likewise.
        * coff-i386.c (_bfd_generic_find_nearest_line_discriminator): Don't
        define.
        * coff-rs6000.c (xcoff_find_nearest_line,
        xcoff_find_nearest_line_discriminator): Delete.
        (_bfd_xcoff_find_nearest_line): Don't define.
        (_bfd_xcoff_find_nearest_line): Define as coff_find_nearest_line.
        * coff-x86_64.c (_bfd_generic_find_nearest_line_discriminator): Don't
        define.
        * coff64-rs6000.c (rs6000_xcoff64_vec, rs6000_xcoff64_aix_vec): Adjust.
        * coffgen.c (coff_find_nearest_line_with_names): Reorder params,
        adjust _bfd_dwarf2_find_nearest_line call.
        (coff_find_nearest_line): Add "discriminator_ptr" param, reorder
        others.  Set discriminator.  Adjust call.
        (coff_find_nearest_line_discriminator): Delete.
        * dwarf1.c (_bfd_dwarf1_find_nearest_line): Reorder params.
        * dwarf2.c (find_line): Rename to..
        (_bfd_dwarf2_find_nearest_line): ..this, reordering params.
        Simplify setting of do_line.  Delete old function.
        (_bfd_dwarf2_find_line): Delete.
        * ecoff.c (_bfd_ecoff_find_nearest_line): Reorder params, add
        discriminator_ptr and set it.
        * elf-bfd.h (_bfd_elf_find_nearest_line): Update prototype.
        (_bfd_elf_find_nearest_line_discriminator): Delete.
        (_bfd_elf_find_line_discriminator): Delete.
        (_bfd_generic_find_nearest_line_discriminator): Don't define.
        * elf.c (elf_find_function): Reorder params.
        (_bfd_elf_find_nearest_line): Reorder params, add discriminator_ptr.
        Adjust calls.
        (_bfd_elf_find_nearest_line_discriminator): Delete.
        (_bfd_elf_find_line): Adjust call.
        * elf32-arm.c (arm_elf_find_function): Reorder params.
        (elf32_arm_find_nearest_line): Reorder params, add discriminator_ptr.
        Adjust calls.
        * elf64-alpha.c (elf64_alpha_find_nearest_line): Similarly.
        * elfnn-aarch64.c (aarch64_elf_find_function): Reorder params.
        (elfNN_aarch64_find_nearest_line): Reorder params, add
        discriminator_ptr.  Adjust calls.
        * elfxx-mips.c (_bfd_mips_elf_find_nearest_line): Similarly.
        * elfxx-mips.h (_bfd_mips_elf_find_nearest_line): Update prototype.
        * libaout.h (NAME (aout, find_nearest_line)): Update prototype.
        * libbfd-in.h (_bfd_nosymbols_find_nearest_line): Update.
        (_bfd_dwarf1_find_nearest_line): Likewise.
        (_bfd_dwarf2_find_nearest_line): Likewise.
        (_bfd_dwarf2_find_line): Delete.
        (_bfd_generic_find_nearest_line_discriminator): Delete.
        * libbfd.c (_bfd_generic_find_nearest_line_discriminator): Delete.
        * libcoff-in.h (coff_find_nearest_line): Update prototype.
        (coff_find_nearest_line_discriminator): Delete.
        (coff_find_nearest_line_with_names): Update prototype.
        * libecoff.h (_bfd_ecoff_find_nearest_line): Update prototype.
        * mach-o.c (bfd_mach_o_find_nearest_line): Reorder params, add
        discriminator_ptr.  Adjust calls.
        * mach-o.h (bfd_mach_o_find_nearest_line): Update prototype.
        * pdp11.c (NAME (aout, find_nearest_line)): Reorder params, add
        discriminator_ptr and set.
        * som.c (som_find_nearest_line): Similarly.
        * targets.c (BFD_JUMP_TABLE_SYMBOLS): Delete entry for
        _bfd_find_nearest_line_discriminator.
        (struct bfd_target <_bfd_find_nearest_line>): Adjust prototype.
        (struct bfd_target <_bfd_find_nearest_line_discriminator>): Delete.
        * vms-alpha.c (_bfd_vms_find_nearest_dst_line): Rename to..
        (_bfd_vms_find_nearest_line): ..this.  Reorder params, add
        "discriminator" and set.
        (_bfd_vms_find_nearest_line_discriminator): Delete.
        (_bfd_generic_find_nearest_line_discriminator): Don't define.
        (alpha_vms_find_nearest_line): Update define.
        * bfd-in2.h: Regenerate.
        * libbfd.h: Regenerate.
        * libcoff.h: Regenerate.

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=952d0b7d11c8e13f74df3651b28c4d49bc4d9d80

commit 952d0b7d11c8e13f74df3651b28c4d49bc4d9d80
Author: Alan Modra <address@hidden>
Date:   Wed Oct 15 15:40:45 2014 +1030

    Define bfd_find_line entry of BFD_JUMP_TABLE_SYMBOLS using NAME

    In https://www.sourceware.org/ml/binutils/2005-06/msg00082.html
    HJ implemented bfd_find_line for DWARF2, but cheated a little in not
    using the usual NAME##_find_line, saving quite a lot of boring
    editing.  However that shortcut probably contributed to
    bfd_find_nearest_line_discriminator being implemented the same way,
    and missing support for some targets.

        * targets.c (BFD_JUMP_TABLE_SYMBOLS): Use NAME##_find_line.
        * aout-adobe.c (aout_32_find_line): Define.
        (aout_32_bfd_make_debug_symbol, aout_32_bfd_reloc_type_lookup,
        aout_32_bfd_reloc_name_lookup): Define using _bfd_nosymbols define.
        * aout-target.h (MY_find_line): Define.
        * aout-tic30.c (MY_find_line): Define.
        * binary.c (binary_find_line): Define.
        * bout.c (aout_32_find_line): Define.
        * coff-rs6000.c (_bfd_xcoff_find_line): Define.
        * coff64-rs6000.c (rs6000_xcoff64_vec): Use coff_find_line.
        (rs6000_xcoff64_aix_vec): Likewise.
        * elf-bfd.h (_bfd_generic_find_line): Don't define.
        * elfxx-target.h (bfd_elfNN_find_line): Define.
        * i386msdos.c (msdos_find_line): Define.
        * i386os9k.c (aout_32_find_line): Define.
        * ieee.c (ieee_find_nearest_line, ieee_find_inliner_info): Delete func.
        (ieee_find_nearest_line, ieee_find_line,
        ieee_find_inliner_info): Define.
        * ihex.c (ihex_find_line): Define.
        * libbfd-in.h (_bfd_nosymbols_find_line): Define.
        (_bfd_generic_find_line): Don't define.
        * libbfd.c (_bfd_generic_find_line): Delete.
        * libcoff-in.h (coff_find_line): Define.
        * libecoff.h (_bfd_ecoff_find_line): Define.
        * mach-o.h (bfd_mach_o_find_line): Define.
        * mmo.c (mmo_find_line): Define.
        * nlm-target.h (nlm_find_line): Define.
        * oasys.c (oasys_find_nearest_line, oasys_find_inliner_info): Delete.
        (oasys_find_nearest_line, oasys_find_line,
        oasys_find_inliner_info): Define.
        * pef.c (bfd_pef_find_line): Define.
        * plugin.c (bfd_plugin_find_line): Define.
        * ppcboot.c (ppcboot_find_line): Define.
        * som.c (som_find_line): Define.
        * srec.c (srec_find_line): Define.
        * tekhex.c (tekhex_find_line): Define.
        * versados.c (versados_find_line): Define.
        * vms-alpha.c (alpha_vms_find_line): Define.
        * xsym.c (bfd_sym_find_line): Define.
        * bfd-in2.h: Regenerate.
        * libbfd.h: Regenerate.
        * libcoff.h: Regenerate.

-----------------------------------------------------------------------

Summary of changes:
 bfd/ChangeLog       |  124 +++++++++++++++++++++++++++++++++++++++++++++++++++
 bfd/aout-adobe.c    |    7 ++-
 bfd/aout-target.h   |    3 +
 bfd/aout-tic30.c    |    3 +
 bfd/aoutx.h         |    7 ++-
 bfd/bfd-in2.h       |   14 ++----
 bfd/bfd.c           |    6 +-
 bfd/binary.c        |    1 +
 bfd/bout.c          |    1 +
 bfd/coff-i386.c     |    3 -
 bfd/coff-rs6000.c   |   38 +---------------
 bfd/coff-x86_64.c   |    3 -
 bfd/coff64-rs6000.c |    6 +--
 bfd/coffgen.c       |   41 +++++------------
 bfd/dwarf1.c        |    2 +-
 bfd/dwarf2.c        |   82 ++++++++-------------------------
 bfd/ecoff.c         |    9 +++-
 bfd/elf-bfd.h       |   12 +----
 bfd/elf.c           |   61 +++++++------------------
 bfd/elf32-arm.c     |   22 +++++----
 bfd/elf64-alpha.c   |   18 ++++---
 bfd/elfnn-aarch64.c |   23 +++++-----
 bfd/elfxx-mips.c    |   24 +++++-----
 bfd/elfxx-mips.h    |    4 +-
 bfd/elfxx-target.h  |    3 +
 bfd/i386msdos.c     |    1 +
 bfd/i386os9k.c      |    1 +
 bfd/ieee.c          |   23 +--------
 bfd/ihex.c          |    1 +
 bfd/libaout.h       |    4 +-
 bfd/libbfd-in.h     |   31 +++++--------
 bfd/libbfd.c        |   23 ---------
 bfd/libbfd.h        |   31 +++++--------
 bfd/libcoff-in.h    |   12 ++---
 bfd/libcoff.h       |   12 ++---
 bfd/libecoff.h      |    5 +-
 bfd/mach-o.c        |   17 +++----
 bfd/mach-o.h        |    8 ++-
 bfd/mmo.c           |    1 +
 bfd/nlm-target.h    |    1 +
 bfd/oasys.c         |   23 +--------
 bfd/pdp11.c         |    7 ++-
 bfd/pef.c           |    1 +
 bfd/plugin.c        |    1 +
 bfd/ppcboot.c       |    1 +
 bfd/som.c           |    9 +++-
 bfd/srec.c          |    1 +
 bfd/targets.c       |    8 +---
 bfd/tekhex.c        |    1 +
 bfd/versados.c      |    1 +
 bfd/vms-alpha.c     |   39 +++++-----------
 bfd/xsym.c          |    1 +
 52 files changed, 359 insertions(+), 422 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]