bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug gold/17670] internal error in symval_for_branch, at powerpc.cc:6755


From: cvs-commit at gcc dot gnu.org
Subject: [Bug gold/17670] internal error in symval_for_branch, at powerpc.cc:6755 during qt5 build
Date: Wed, 03 Dec 2014 23:14:21 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=17670

--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".

The branch, master has been updated
       via  1611bc4afb0f08f0aff64ec355b8d68e9f4f0a73 (commit)
      from  858339f2b7aafe199c1cd07fc8d4a7c8130aa285 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1611bc4afb0f08f0aff64ec355b8d68e9f4f0a73

commit 1611bc4afb0f08f0aff64ec355b8d68e9f4f0a73
Author: Alan Modra <address@hidden>
Date:   Wed Dec 3 16:17:23 2014 +1030

    powerpc gold, work around pr17670

    pr17670 is about an assert triggering on a branch to an undefined
    weak symbol, the symbol being undefined due to dropping its comdat
    group section.  (Well sort of.  The symbol is actually defined in
    an .opd section which isn't part of the group, but the code section
    the opd entry points at is dropped.)  So don't assert.
    Also, don't make long branch stubs to such symbols, and arrange to
    have target-reloc.h code warn when applying relocs that use the sym.

        PR 17670
        * symtab.cc (Symbol::set_undefined): Remove assertion.
        * powerpc.cc (Target_powerpc::symval_for_branch): Don't assert
        on symbols defined in discarded sections, instead return false.
        Rearrange params, update all callers.
        (Target_powerpc::Branch_info::make_stub): Don't make stubs for
        branches to syms in discarded sections.
        (Global_symbol_visitor_opd::operator()): Set discarded opd syms
        undefined and flag as discarded.
        (Target_powerpc::Relocate::relocate): Localize variable.

-----------------------------------------------------------------------

Summary of changes:
 gold/ChangeLog  |   13 +++++++++++++
 gold/powerpc.cc |   54 +++++++++++++++++++++++++++++++-----------------------
 gold/symtab.cc  |    1 -
 3 files changed, 44 insertions(+), 24 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]