bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

tc-v850.c:1663: possible bad if condition ?


From: David Binderman
Subject: tc-v850.c:1663: possible bad if condition ?
Date: Mon, 2 Mar 2015 10:34:49 +0000

Hello there,

[src/gas/config/tc-v850.c:1663]: (style) Expression is always false because 
'else if' condition matches previous condition at line 1655.

Source code is

  else if (strcmp (arg, "8byte-align") == 0)
    v850_data_8 = TRUE;
  else if (strcmp (arg, "4byte-align") == 0)
    v850_data_8 = FALSE;
  else if (strcmp (arg, "soft-float") == 0)
    soft_float = 1;
  else if (strcmp (arg, "hard-float") == 0)
    soft_float = 0;
  else if (strcmp (arg, "8byte-align") == 0)
    v850_e_flags |= EF_RH850_DATA_ALIGN8;
  else if (strcmp (arg, "4byte-align") == 0)
    v850_e_flags &= ~ EF_RH850_DATA_ALIGN8;

The last two conditions will never be true. Suggest code rework.

Regards

David Binderman

                                          


reply via email to

[Prev in Thread] Current Thread [Next in Thread]