bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug gold/14217] internal error in set_offset


From: cvs-commit at gcc dot gnu.org
Subject: [Bug gold/14217] internal error in set_offset
Date: Sun, 22 Mar 2015 05:31:42 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=14217

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> ---
The master branch has been updated by Cary Coutant <address@hidden>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=bccffdfdf268a84533131d6e4d6208f9873892ee

commit bccffdfdf268a84533131d6e4d6208f9873892ee
Author: Cary Coutant <address@hidden>
Date:   Sat Mar 21 22:30:44 2015 -0700

    Fix internal error with -z relro when .tbss is last relro section.

    When calculating the padding necessary to align the end of the relro
    segment to a page boundary, gold erroneously ignores the .tdata section
    when checking to see if there are any relro sections (so if .tdata
    is the only relro section, we fail to align the segment properly),
    and erroneously pads the cumulative size of the segment based on
    the alignment of .tbss. If there are no relro sections following .tbss,
    it then fails to note the padding needed at the end of .tdata.

    This patch fixes both problems. is_first_section_relro() will return
    true when it sees a .tdata section, and we do not align the cumulative
    size until after checking for the .tbss section.

    gold/
        PR gold/14217
        * output.cc (Output_segment::is_first_section_relro): Don't ignore
        .tdata section.
        (Output_segment::set_section_addresses): Don't align size of relro
        segment for .tbss.

-- 
You are receiving this mail because:
You are on the CC list for the bug.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]