[Bug binutils/18750] Stack buffer overflow when printing bad bytes in Intel Hex objects

[tyhicks at canonical dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18750

--- Comment #7 from Tyler Hicks <tyhicks at canonical dot com> ---
(In reply to Yuriy Kaminskiy from comment #6)
> Created attachment 8470 [details]
> Fix incorrect escape sequence on platform with signed char (v3)
> 
> ... and similar bug (but just incorrect output, without stack overflow) in
> binutils/readelf.c (process_mips_specific).
> (all other `git grep '%03o'` instances looks safe).
> 
> Re: tyhicks (#5): wrong, look carefully at srec.c:
> 
> L299  int c;
> ...
> L457        char hdr[3];
> ...
> L473        c = hdr[1];
> ...
> L476        srec_bad_byte (abfd, lineno, c, error);
> *BOOM*

Hrm? You must be looking at an old version of the code. It was changed in the
last hunk of this patch:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=708d7d0d

-- 
You are receiving this mail because:
You are on the CC list for the bug.