[Bug gas/18561] sh assembler wrongly constant-folds address expressions containing weak symbols

[bugdal at aerifal dot cx]

https://sourceware.org/bugzilla/show_bug.cgi?id=18561

--- Comment #4 from Rich Felker <bugdal at aerifal dot cx> ---
Indeed, that fixes it. However I'm skeptical of the way you're making the
change:

1. S_FORCE_RELOC already has logic to force relocations for weak symbols when
the strict argument is nonzero, so I wonder if something is wrongly calling it
with strict=0 instead of strict=1?

2. Resolving the value of a weak symbol at as-time is always wrong, regardless
of target or 'strictness' (whatever that's intended to mean). If the bug were
in an sh-specific file, I would be satisfied with an sh-specific fix, but since
it seems to be in symbol.c, this may indicate a bug that's affecting other
targets too, and that should be fixed globally rather than via a
target-specific optional macro.

Thoughts?

-- 
You are receiving this mail because:
You are on the CC list for the bug.