[Bug gas/18561] sh assembler wrongly constant-folds address expressions containing weak symbols

[nickc at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18561

Nick Clifton <nickc at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #5 from Nick Clifton <nickc at redhat dot com> ---
Hi Rich,

> Indeed, that fixes it. However I'm skeptical of the way you're making the
> change:

Me too - it was just a suggestion.

> 1. S_FORCE_RELOC already has logic to force relocations for weak symbols
> when the strict argument is nonzero, so I wonder if something is wrongly
> calling it with strict=0 instead of strict=1?

This seems likely, although I have to wonder - why is this bug only surfacing
now ?  Surely a problem like this, if it is generic, should have been
encountered a long time ago.

> 2. Resolving the value of a weak symbol at as-time is always wrong,

True. So maybe what we need is a patch to S_FORCE_RELOC to always force
relocations for weak symbols...  I will try one out locally and see if it
works.

-- 
You are receiving this mail because:
You are on the CC list for the bug.