[Bug gold/19172] gold is missing emulations, at least on aarch64-linux, arm-linux-gnueabi, powerpc-linux

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19172

--- Comment #5 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Cary Coutant from comment #4)
> > Created attachment 8744 [details]
> > A different patch
> 
> How about just printing a warning instead when we ignore the -m option?
> 
> diff --git a/gold/parameters.cc b/gold/parameters.cc
> index 15df42a..5f5dae0 100644
> --- a/gold/parameters.cc
> +++ b/gold/parameters.cc
> @@ -301,11 +301,8 @@ set_parameters_target(Target* target)
>      {
>        const char* emulation = parameters->options().m();
>        Target* output = select_target_by_emulation(emulation);
> -      if (!output)
> -     gold_error(_("unrecognised output emulation: %s"), emulation);
> -      else if (output != target)
> -     gold_error(_("input file is incompatible with %s output emulation"),
> -                emulation);
> +      if (output != target)
> +     gold_warning(_("ignoring requested emulation %s"), emulation);
>      }
>    static_parameters.set_target(target);
>  }

It is wrong to ignore the unrecognised output emulation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.