[Bug binutils/19435] objdump receives SIGABRT when disassembling Mach O binary on OS X

[nickc at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19435

Nick Clifton <nickc at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #5 from Nick Clifton <nickc at redhat dot com> ---
Hi Ian,

  Sorry for dropping the ball on this one.

  I am still not able to reproduce the problem, but I suspect that is because I
do not have the dsym file that is associated with the test binary that you
uploaded.  Still there may a solution.  There is only one call to free() inside
bfd_mach_o_close_and_cleanup(), if you ignore calls made by inferior functions,
and that is to free an allocated filename.  So please could you try out this
patch:

diff --git a/bfd/mach-o.c b/bfd/mach-o.c
index 72454f9..e0eaf3a 100644
--- a/bfd/mach-o.c
+++ b/bfd/mach-o.c
@@ -5805,7 +5805,7 @@ bfd_mach_o_close_and_cleanup (bfd *abfd)
           mdata->dsym_bfd = NULL;
           if (fat_bfd)
             bfd_close (fat_bfd);
-          free (dsym_filename);
+          /*free (dsym_filename);*/
         }
     }

and let me know if it works.  It does mean that there would be a memory leak in
the mach-o backend, but not a serious one, and since the function is part of
the closing sequence it should not last for very long.

I did look at where dsym_filename might have been allocated, but it appears to
be a very tortuous route to where bfd_mach_o_close_and_cleanup tries to find
it.

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.