[Bug ld/17334] building gcc-4.5.4 hits BFD (GNU Binutils) 2.25 assertion fail elf32-bfin.c:4457

[wbx at openadk dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17334

wbx at openadk dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|2.25                        |2.26

--- Comment #6 from wbx at openadk dot org ---
I think the assert might be not required.
I used git bisect and found that following commit made
the assert to be fatal for toolchain creation:
2b56b3f35a62c569ff20889aa22aef7fde73f81d

When I just simply remove the assert I can just build
a toolchain and a Linux system including uClibc-ng and buildroot 
boots up fine in the GDB simulator. (FPIC)

So is this assert really required?

diff -Nur binutils-2.26.orig/bfd/elf32-bfin.c binutils-2.26/bfd/elf32-bfin.c
--- binutils-2.26.orig/bfd/elf32-bfin.c 2015-11-13 09:27:40.000000000 +0100
+++ binutils-2.26/bfd/elf32-bfin.c      2016-02-08 01:14:15.360648022 +0100
@@ -4456,9 +4456,6 @@

   if (bfinfdpic_got_section (info))
     {
-      BFD_ASSERT (bfinfdpic_gotrel_section (info)->size
-                 == (bfinfdpic_gotrel_section (info)->reloc_count
-                     * sizeof (Elf32_External_Rel)));

       if (bfinfdpic_gotfixup_section (info))
        {

-- 
You are receiving this mail because:
You are on the CC list for the bug.