[Bug gold/19794] New: src/gold/archive.cc: 2 * pointless copy ?

[dcb314 at hotmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19794

            Bug ID: 19794
           Summary: src/gold/archive.cc: 2 * pointless copy ?
           Product: binutils
           Version: 2.27 (HEAD)
            Status: NEW
          Severity: minor
          Priority: P2
         Component: gold
          Assignee: ccoutant at gmail dot com
          Reporter: dcb314 at hotmail dot com
                CC: ian at airs dot com
  Target Milestone: ---

1.

[src/gold/archive.cc:506]: (performance) Function parameter 'p' should be
passed by reference.

Source code is

  operator==(const const_iterator p) const

More usual would be

  operator==(const const_iterator & p) const

2.

[src/gold/archive.cc:510]: (performance) Function parameter 'p' should be
passed by reference.

Duplicate.

-- 
You are receiving this mail because:
You are on the CC list for the bug.