bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug ld/19803] gc-sections breaks PE DLL variable export


From: nickc at redhat dot com
Subject: [Bug ld/19803] gc-sections breaks PE DLL variable export
Date: Fri, 18 Mar 2016 11:37:05 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=19803

--- Comment #11 from Nick Clifton <nickc at redhat dot com> ---
Created attachment 9107
  --> https://sourceware.org/bugzilla/attachment.cgi?id=9107&action=edit
Patch VII

Hi Martin,

  I like the patch, but I have one question: why did you need to use xstrdup to
make a copy of the name in the exports array ?

  I have uploaded a tweaked version of your patch, which apart from ditching
the xstrdup (which may be a mistake, depending upon your answer), also takes
the code to add a symbol to the gc_sym_list and moves it into its open separate
function.  The code was being duplicated in four different places, so it seemed
like a good idea.

  Please could you give this patch a quick test, and if it is OK I will check
it in.

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]