[Bug binutils/20000] New: src/sim/rx/fpu.c:436: possible typo ?

[dcb314 at hotmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=20000

            Bug ID: 20000
           Summary: src/sim/rx/fpu.c:436: possible typo ?
           Product: binutils
           Version: 2.27 (HEAD)
            Status: NEW
          Severity: normal
          Priority: P2
         Component: binutils
          Assignee: unassigned at sourceware dot org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

[src/sim/rx/fpu.c:436]: (style) Expression is always false because 'else if'
condition matches previous condition at line 434.

Source code is

     if (a->type == FP_SNAN)
        *c = a->orig_value | 0x00400000;
      else if  (a->type == FP_SNAN)
        *c = b->orig_value | 0x00400000;
      else
        *c = 0x7fc00000;

Maybe better code

     if (a->type == FP_SNAN)
        *c = a->orig_value | 0x00400000;
      else if  (b->type == FP_SNAN)
        *c = b->orig_value | 0x00400000;
      else
        *c = 0x7fc00000;

-- 
You are receiving this mail because:
You are on the CC list for the bug.