[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug ld/16467] ld fails with internal error in elf_x86_64_relocate_secti

From: cvs-commit at gcc dot gnu.org
Subject: [Bug ld/16467] ld fails with internal error in elf_x86_64_relocate_section when .symver and ifunc magic is used
Date: Thu, 09 Jun 2016 10:23:42 +0000


--- Comment #17 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> ---
The binutils-2_26-branch branch has been updated by Alan Modra


commit bdf48af13cdaccdcbcc0aca9c41ae376038508fd
Author: Alan Modra <address@hidden>
Date:   Mon May 30 09:43:44 2016 +0930

    Revert PR16467 change

    This reverts the pr16467 change, which was incorrect due to faulty
    analysis of the pr16467 testcase.  The failure was not due to a
    mismatch in symbol type (ifunc/non-ifunc) but due to a symbol loop
    being set up.

    See https://sourceware.org/ml/binutils/2016-06/msg00013.html for some
    rambling on versioned symbols and ELF shared library symbol overriding
    that explain this patch.

        PR ld/20159
        PR ld/16467
        * elflink.c (_bfd_elf_merge_symbol): Revert PR16467 change.
        (_bfd_elf_add_default_symbol): Don't indirect to/from defined
        symbol given a version by a script different to the version
        of the symbol being added.
        (elf_link_add_object_symbols): Use _bfd_elf_strtab_save and
        _bfd_elf_strtab_restore.  Don't fudge dynstr references.
        * elf-strtab.c (_bfd_elf_strtab_restore_size): Delete.
        (struct strtab_save): New.
        (_bfd_elf_strtab_save, _bfd_elf_strtab_restore): New functions.
        * elf-bfd.h (_bfd_elf_strtab_restore_size): Delete.
        (_bfd_elf_strtab_save, _bfd_elf_strtab_restore): Declare.

You are receiving this mail because:
You are on the CC list for the bug.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]