bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug gprof/20656] New: double assignment in source.c


From: tromey at sourceware dot org
Subject: [Bug gprof/20656] New: double assignment in source.c
Date: Thu, 29 Sep 2016 22:02:32 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=20656

            Bug ID: 20656
           Summary: double assignment in source.c
           Product: binutils
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gprof
          Assignee: unassigned at sourceware dot org
          Reporter: tromey at sourceware dot org
  Target Milestone: ---

This comes from bug 20613 and http://www.viva64.com/en/b/0430/

source.c has:

          if (new_line)
            {
              (*annote) (annotation, max_width, line_num, arg);
              fputs (annotation, ofp);
              ++line_num;
              new_line = FALSE;
            }

          new_line = (buf[i] == '\n');

The first assignment to new_line is redundant here.
Or maybe there is a missing "else".  I didn't read closely.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]