bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug ld/20828] GC-ed DSO symbols make corresponding symbols defined by a


From: cvs-commit at gcc dot gnu.org
Subject: [Bug ld/20828] GC-ed DSO symbols make corresponding symbols defined by a linker script local
Date: Mon, 13 Feb 2017 14:33:07 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=20828

--- Comment #33 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> ---
The binutils-2_28-branch branch has been updated by Maciej W. Rozycki
<address@hidden>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e7ec0c47c5500b572b847cddd5b0868ef3784473

commit e7ec0c47c5500b572b847cddd5b0868ef3784473
Author: Maciej W. Rozycki <address@hidden>
Date:   Thu Feb 2 22:05:46 2017 +0000

    MIPS/BFD: Respect the ELF gABI dynamic symbol table sort requirement

    Ensure all local symbols precede external symbols in the dynamic symbol
    table.

    No local symbols are expected to make it to the dynamic symbol table
    except for section symbols already taken care of, so this is really a
    safeguard only against a potential BFD bug otherwise not so harmful,
    which may become a grave one due to a symbol table sorting requirement
    violation (see PR ld/20828 for an example).  This means however that no
    test suite coverage is possible for this change as code introduced here
    is not normally expected to trigger.

    Logically split then the part of the dynamic symbol table which is not
    global offset table mapped, into a local area at the beginning and an
    external area following.  By the time `mips_elf_sort_hash_table' is
    called we have the number of local dynamic symbol table entries (section
    and non-section) already counted in `local_dynsymcount', so use it to
    offset the external area from the beginning.

        bfd/
        * elfxx-mips.c (mips_elf_hash_sort_data): Add
        `max_local_dynindx'.
        (mips_elf_sort_hash_table): Handle it.
        (mips_elf_sort_hash_table_f) <GGA_NONE>: For forced local
        symbols bump up `max_local_dynindx' rather than
        `max_non_got_dynindx'.

    (cherry picked from commit e17b0c351f0b22fb42edf34e5a6e486d72e9ee05)

-- 
You are receiving this mail because:
You are on the CC list for the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]